]> Pileus Git - ~andy/linux/commitdiff
[media] mt9v032: Correct the logic for the auto-exposure setting
authorKartik Mohta <kartikmohta@gmail.com>
Wed, 2 May 2012 22:19:08 +0000 (19:19 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 14 May 2012 16:39:02 +0000 (13:39 -0300)
The driver uses the ctrl value passed in as a bool to determine whether
to enable auto-exposure, but the auto-exposure setting is defined as an
enum where AUTO has a value of 0 and MANUAL has a value of 1. This leads
to a reversed logic where if you send in AUTO, it actually sets manual
exposure and vice-versa.

Signed-off-by: Kartik Mohta <kartikmohta@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/mt9v032.c

index 75e253a343c596c6ad946e99f0256115beb81428..4ba4884c016eccfec828ecbc67134f6949c5e634 100644 (file)
@@ -481,7 +481,7 @@ static int mt9v032_s_ctrl(struct v4l2_ctrl *ctrl)
 
        case V4L2_CID_EXPOSURE_AUTO:
                return mt9v032_update_aec_agc(mt9v032, MT9V032_AEC_ENABLE,
-                                             ctrl->val);
+                                             !ctrl->val);
 
        case V4L2_CID_EXPOSURE:
                return mt9v032_write(client, MT9V032_TOTAL_SHUTTER_WIDTH,