]> Pileus Git - ~andy/linux/commitdiff
perf tests: Omit end of the symbol check failure for test 1
authorJiri Olsa <jolsa@redhat.com>
Fri, 7 Jun 2013 13:37:02 +0000 (15:37 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 12 Jul 2013 16:45:50 +0000 (13:45 -0300)
Omitting end of the function check failure for test 1, since there's no
way to get exact symbol end via kallsyms.

Leaving the debug message.

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1370612223-19188-2-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/vmlinux-kallsyms.c

index 7b4c4d26d1baed24e2c5999d76457616c78c5d91..add15392c62220cf6bfa56d7ff3069a8528cf574 100644 (file)
@@ -139,11 +139,18 @@ next_pair:
                                 * _really_ have a problem.
                                 */
                                s64 skew = sym->end - pair->end;
-                               if (llabs(skew) < page_size)
-                                       continue;
+                               if (llabs(skew) >= page_size)
+                                       pr_debug("%#" PRIx64 ": diff end addr for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
+                                                sym->start, sym->name, sym->end, pair->end);
+
+                               /*
+                                * Do not count this as a failure, because we
+                                * could really find a case where it's not
+                                * possible to get proper function end from
+                                * kallsyms.
+                                */
+                               continue;
 
-                               pr_debug("%#" PRIx64 ": diff end addr for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
-                                        sym->start, sym->name, sym->end, pair->end);
                        } else {
                                struct rb_node *nnd;
 detour: