]> Pileus Git - ~andy/linux/commitdiff
debugfs: remove unneeded cast in debugfs_print_regs32()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 24 Nov 2011 07:22:08 +0000 (10:22 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 27 Nov 2011 04:12:47 +0000 (20:12 -0800)
The cast here causes a Sparse warning:
fs/debugfs/file.c:561:42: warning: cast removes address space of expression
fs/debugfs/file.c:561:42: warning: incorrect type in argument 1 (different address spaces)
fs/debugfs/file.c:561:42:    expected void const volatile [noderef] <asn:2>*addr
fs/debugfs/file.c:561:42:    got void *<noident>

It's redundant to cast it to a (void *) anyway when it is already a
(void __iomem *).

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/debugfs/file.c

index e0a3a59a67449514a06df6a249f662ebb283ed3f..989f07fb86f7d1ed95b8c9e1c072f07ff02cce51 100644 (file)
@@ -558,7 +558,7 @@ int debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
                if (prefix)
                        ret += seq_printf(s, "%s", prefix);
                ret += seq_printf(s, "%s = 0x%08x\n", regs->name,
-                                 readl((void *)(base + regs->offset)));
+                                 readl(base + regs->offset));
        }
        return ret;
 }