]> Pileus Git - ~andy/linux/commitdiff
perf probe: Fix to copy the type for raw parameters
authorMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Tue, 3 Aug 2010 02:11:36 +0000 (11:11 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 6 Aug 2010 19:25:56 +0000 (16:25 -0300)
Copy type field if it is for raw parameters.
Without this fix, perf probe drops the type if user passes it
for raw parameters (e.g. %ax:u32 will be converted to %ax).

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
LKML-Reference: <4C577AD8.50808@hitachi.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-finder.c

index 6c7750da43d766f591817f884d8950f1d7c879f3..525136684d4ec170201b4d07c7b080b73851edf9 100644 (file)
@@ -705,8 +705,12 @@ static int find_variable(Dwarf_Die *sp_die, struct probe_finder *pf)
                pf->tvar->value = strdup(pf->pvar->var);
                if (pf->tvar->value == NULL)
                        return -ENOMEM;
-               else
-                       return 0;
+               if (pf->pvar->type) {
+                       pf->tvar->type = strdup(pf->pvar->type);
+                       if (pf->tvar->type == NULL)
+                               return -ENOMEM;
+               }
+               return 0;
        }
 
        pr_debug("Searching '%s' variable in context.\n",