]> Pileus Git - ~andy/linux/commitdiff
ipvs: ip_vs_sh: ip_vs_sh_get_port: check skb_header_pointer for NULL
authorDaniel Borkmann <dborkman@redhat.com>
Tue, 6 Aug 2013 09:20:23 +0000 (11:20 +0200)
committerSimon Horman <horms@verge.net.au>
Tue, 6 Aug 2013 23:57:57 +0000 (08:57 +0900)
skb_header_pointer could return NULL, so check for it as we do it
everywhere else in ipvs code. This fixes a coverity warning.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
net/netfilter/ipvs/ip_vs_sh.c

index f16c027df15bb38241d6750428fdad1733de88ac..3588faebe5298149b918614656ca8b6ee7d12e4e 100644 (file)
@@ -269,14 +269,20 @@ ip_vs_sh_get_port(const struct sk_buff *skb, struct ip_vs_iphdr *iph)
        switch (iph->protocol) {
        case IPPROTO_TCP:
                th = skb_header_pointer(skb, iph->len, sizeof(_tcph), &_tcph);
+               if (unlikely(th == NULL))
+                       return 0;
                port = th->source;
                break;
        case IPPROTO_UDP:
                uh = skb_header_pointer(skb, iph->len, sizeof(_udph), &_udph);
+               if (unlikely(uh == NULL))
+                       return 0;
                port = uh->source;
                break;
        case IPPROTO_SCTP:
                sh = skb_header_pointer(skb, iph->len, sizeof(_sctph), &_sctph);
+               if (unlikely(sh == NULL))
+                       return 0;
                port = sh->source;
                break;
        default: