Bug 549354 – Crash trying to open a file on a remote folder

2008-08-26  Matthias Clasen  <mclasen@redhat.com>

        Bug 549354 – Crash trying to open a file on a remote folder

        * gtk/gtkfilechooserdefault.c (error_message_with_parent): Handle
        the fact that parent may be NULL without crashing.

svn path=/trunk/; revision=21206

diff --git a/ChangeLog b/ChangeLog
index 50b849a9b899ab7d382f24aa9e674cd2fd8f2b20..fd2b4048c6bdde41ac90f79a7614b974198ac1fa 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-08-26  Matthias Clasen  <mclasen@redhat.com>
+
+       Bug 549354 – Crash trying to open a file on a remote folder
+
+       * gtk/gtkfilechooserdefault.c (error_message_with_parent): Handle
+       the fact that parent may be NULL without crashing. 
+
 2008-08-25  Matthias Clasen  <mclasen@redhat.com>
 
        * modules/printbackends/cups/gtkprintbackendcups.c: Replace 

diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c
index 6e82cff1c4dab91065e7048a752f203209d801f4..71eadcf7a39d1cdaae1adc9ff963e4ba135593af 100644 (file)
--- a/gtk/gtkfilechooserdefault.c
+++ b/gtk/gtkfilechooserdefault.c
@@ -990,7 +990,7 @@ error_message_with_parent (GtkWindow  *parent,
   gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
                                            "%s", detail);
 
-  if (parent->group)
+  if (parent && parent->group)
     gtk_window_group_add_window (parent->group, GTK_WINDOW (dialog));
 
   gtk_dialog_run (GTK_DIALOG (dialog));