bgo533891 - disallow DnD from the file list into itself

2008-05-27  Federico Mena Quintero  <federico@novell.com>

	http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow
	drag and drop from the file list into itself, as it doesn't make
	sense (it would just change the current folder).

	* gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use
	GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into
	itself.

Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20194

diff --git a/ChangeLog b/ChangeLog
index 6a1a5a9ba1ced0bb01f31a831e51c541c48f9177..021336e0cdaadd792d72cbbc3adbef6bcc812b07 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2008-05-27  Federico Mena Quintero  <federico@novell.com>
+
+       http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow
+       drag and drop from the file list into itself, as it doesn't make
+       sense (it would just change the current folder).
+
+       * gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use
+       GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into
+       itself.
+
 2008-05-27  Michael Natterer  <mitch@imendio.com>
 
        * gtk/gtksignal.h: move deprecated guards around everything,

diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c
index 00227a8fa83737ce4972851eb95e219fffecd197..dcc28642a7fcc098996ef2fa1b369337104b5217 100644 (file)
--- a/gtk/gtkfilechooserdefault.c
+++ b/gtk/gtkfilechooserdefault.c
@@ -258,7 +258,7 @@ static const int num_file_list_source_targets = G_N_ELEMENTS (file_list_source_t
 
 /* Target types for dropping into the file list */
 static const GtkTargetEntry file_list_dest_targets[] = {
-  { "text/uri-list", 0, TEXT_URI_LIST }
+  { "text/uri-list", GTK_TARGET_OTHER_WIDGET, TEXT_URI_LIST }
 };
 
 static const int num_file_list_dest_targets = G_N_ELEMENTS (file_list_dest_targets);