app-admin/collectd: added trailing slash to HOMEPAGE URI; added a looot of quotes...

svn path=/sunrise/; revision=4088

diff --git a/app-admin/collectd/ChangeLog b/app-admin/collectd/ChangeLog
index ffd3a2df9c389afad7fc2a89d43160320b694b77..e7d43fd34927b326baf9880a25d73dcd5c2e6f2e 100644 (file)
--- a/app-admin/collectd/ChangeLog
+++ b/app-admin/collectd/ChangeLog
@@ -2,6 +2,13 @@
 # Copyright 1999-2007 Gentoo Foundation; Distributed under the GPL v2
 # $Header: $
 
+  29 Jun 2007; Christian Faulhammer <opfer@gentoo.org>
+  collectd-4.0.4.ebuild:
+  added trailing slash to HOMEPAGE URI; added a looot of quotes and this
+  myconf construct is just not necessary; exchange make with emake and use
+  canonical die comments. Please make sure your ebuilds stick at least a bit
+  to the normal QA standards
+
   28 Jun 2007; Wolfgang Frisch (xororand) <xororand@frexx.de>
   +collectd-4.0.4.ebuild, +files/collectd-4.0.4.confd,
   +files/collectd-4.0.4.initd, +metadata.xml:

diff --git a/app-admin/collectd/Manifest b/app-admin/collectd/Manifest
index 42008303c502b9ebed39c2837ad73d4535518c39..19f46dd9f36d7e44e9586f0011dcbca777dba342 100644 (file)
--- a/app-admin/collectd/Manifest
+++ b/app-admin/collectd/Manifest
@@ -1,6 +1,6 @@
 AUX collectd-4.0.4.confd 529 RMD160 52920082294789ed9b46d2db37ae85a697587070 SHA1 5993dc1aa3a1a51464ffe84b2f3133c343253739 SHA256 93841388cdc88bc9cc8916a33892191e7cb1ce5557f76051d5b65ef0ea4cc558
 AUX collectd-4.0.4.initd 655 RMD160 e6386b437fb6175cf35e3207a16a938341e70513 SHA1 5c9684f94b95ef1a835cdc0402003ec9966d2e96 SHA256 642c8463dfa0c49b71b9e145b2913ae59371b43f4dd6671c1701fa03b0b3140c
 DIST collectd-4.0.4.tar.bz2 709151 RMD160 656d56ec5c13274f6b2af4f6ebb655db9cadcf09 SHA1 cf9b22ab588927cbda42031ec5bc0ee3e655cc22 SHA256 ad2f27ecc52b0f3a7bc9717e903a81223767184a4e18a04a5de7245639855afa
-EBUILD collectd-4.0.4.ebuild 1422 RMD160 f1fec459a41e54fc44ce9b716c0be79ef2f3f37a SHA1 76087b6ef5ad6141e62c3990faf112e0ae123a26 SHA256 8ef1baba5f57fb2aa0d13015db1c87caad385885dd3f3fade0f1932cd7a15ee0
-MISC ChangeLog 311 RMD160 9167e69016b7db4ff8210522e06dcdd7b9090754 SHA1 ab74d4893a01337dd3486b45903da0b143bca456 SHA256 3e1c88b7c584bc34e41022bb7538af1ac455fb573f268e09bf7d7c8d4b06d446
+EBUILD collectd-4.0.4.ebuild 1265 RMD160 824fb99e1630c948163e4c3ab42bfbde599ed414 SHA1 98ee4ba7062d0623864f2d3a8435d7bf33d3e6da SHA256 49eaeb9015d1063bd6280db6cf2cd6d8ad60dc3412108908d1996358d27e65ba
+MISC ChangeLog 646 RMD160 f2a6d3ee98bc3e562186f5699906df9511e9813b SHA1 77ac96373878216ead62631880f1e0a49fad1184 SHA256 fa73a2287a5951024529896cf729e4aeb46589eba1bfd37e5e79457120ff647a
 MISC metadata.xml 170 RMD160 645927a396fdc21cdeb089fe42c5397332420ea6 SHA1 ac7f48a14fec325926f9ce1be8fbf1f311b4f2e4 SHA256 d797a2ec6f9dc516c9f9c1a758ee87ad3e8c43101b5dc76c2f872d5bd4639b42

diff --git a/app-admin/collectd/collectd-4.0.4.ebuild b/app-admin/collectd/collectd-4.0.4.ebuild
index 11e997970be6fba323030f21589ce01bad5a04f4..3e7051a36ccf8a9af179cef778940a063b460634 100644 (file)
--- a/app-admin/collectd/collectd-4.0.4.ebuild
+++ b/app-admin/collectd/collectd-4.0.4.ebuild
@@ -5,7 +5,7 @@
 inherit eutils
 
 DESCRIPTION="A small daemon to collect system statistics into RRD files."
-HOMEPAGE="http://collectd.org"
+HOMEPAGE="http://collectd.org/"
 SRC_URI="http://collectd.org/files/${P}.tar.bz2"
 
 LICENSE="GPL-2"
@@ -13,31 +13,21 @@ SLOT="0"
 KEYWORDS="~x86 ~amd64"
 IUSE="lm_sensors hddtemp mysql perl"
 
-DEPEND="
-       net-misc/curl
+DEPEND="net-misc/curl
        >=net-analyzer/rrdtool-1.2
        hddtemp? ( app-admin/hddtemp )
        lm_sensors? ( >=sys-apps/lm_sensors-2.9.0 )
        mysql? ( >=dev-db/mysql-4.1 )"
 
 src_compile() {
-       local myconf="
-               --prefix=/usr
-               --mandir=/usr/share/man
-               --infodir=/usr/share/info
-               --datadir=/usr/share
-               --sysconfdir=/etc
-               --localstatedir=/var
-               $(use_enable lm_sensors sensors)
-               $(use_enable mysql)
-               $(use_enable perl)"
-       econf $myconf
-       emake || die "compile problem"
+       econf $(use_enable lm_sensors sensors) $(use_enable mysql) \
+               $(use_enable perl)
+       emake || die "emake failed"
 }
 
 src_install() {
-       make DESTDIR=${D} install || die install failed
-       
+       emake DESTDIR="${D}" install || die "install failed"
+
        dodoc AUTHORS ChangeLog README NEWS TODO
 
        docinto contrib
@@ -45,11 +35,11 @@ src_install() {
 
        keepdir /var/lib/collectd
 
-       newinitd ${FILESDIR}/${P}.initd collectd
-       newconfd ${FILESDIR}/${P}.confd collectd
+       newinitd "${FILESDIR}/${P}.initd" collectd
+       newconfd "${FILESDIR}/${P}.confd" collectd
 
        insinto /etc
-       newins ${FILESDIR}/${P}.conf collectd.conf
+       newins "${FILESDIR}/${P}.conf" collectd.conf
 }
 
 pkg_postinst() {