]> Pileus Git - ~andy/linux/commitdiff
ovs: fix dp check in ovs_dp_reset_user_features
authorJiri Pirko <jiri@resnulli.us>
Fri, 14 Feb 2014 10:42:36 +0000 (11:42 +0100)
committerJesse Gross <jesse@nicira.com>
Sun, 16 Feb 2014 01:24:19 +0000 (17:24 -0800)
This fixes crash when userspace does "ovs-dpctl add-dp dev" where dev is
existing non-dp netdevice.

Introduced by:
commit 44da5ae5fbea4686f667dc854e5ea16814e44c59
"openvswitch: Drop user features if old user space attempted to create datapath"

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Jesse Gross <jesse@nicira.com>
net/openvswitch/datapath.c

index e9a48baf85510f92a5d29aceed7d27acce24035a..e42340d3f8207ba544efe9f4702c9c55fb14d40d 100644 (file)
@@ -1174,7 +1174,7 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb, struct genl_info *in
        struct datapath *dp;
 
        dp = lookup_datapath(sock_net(skb->sk), info->userhdr, info->attrs);
-       if (!dp)
+       if (IS_ERR(dp))
                return;
 
        WARN(dp->user_features, "Dropping previously announced user features\n");