]> Pileus Git - ~andy/linux/commitdiff
pinctrl: tegra: Convert to devm_ioremap_resource
authorAxel Lin <axel.lin@ingics.com>
Tue, 27 Aug 2013 01:07:23 +0000 (09:07 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 28 Aug 2013 11:34:18 +0000 (13:34 +0200)
Using the new devm_ioremap_resource() we can greatly simplify resource handling.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-tegra.c

index 637bcd341c7d80ec7d1fa444c5f167ed3cdd6e22..be7e900fb2982f04c5d71cdc24eef59cada2cd29 100644 (file)
@@ -643,25 +643,9 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
 
        for (i = 0; i < pmx->nbanks; i++) {
                res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-               if (!res) {
-                       dev_err(&pdev->dev, "Missing MEM resource\n");
-                       return -ENODEV;
-               }
-
-               if (!devm_request_mem_region(&pdev->dev, res->start,
-                                           resource_size(res),
-                                           dev_name(&pdev->dev))) {
-                       dev_err(&pdev->dev,
-                               "Couldn't request MEM resource %d\n", i);
-                       return -ENODEV;
-               }
-
-               pmx->regs[i] = devm_ioremap(&pdev->dev, res->start,
-                                           resource_size(res));
-               if (!pmx->regs[i]) {
-                       dev_err(&pdev->dev, "Couldn't ioremap regs %d\n", i);
-                       return -ENODEV;
-               }
+               pmx->regs[i] = devm_ioremap_resource(&pdev->dev, res);
+               if (IS_ERR(pmx->regs[i]))
+                       return PTR_ERR(pmx->regs[i]);
        }
 
        pmx->pctl = pinctrl_register(&tegra_pinctrl_desc, &pdev->dev, pmx);