]> Pileus Git - ~andy/linux/commitdiff
edac: allow specifying the error count with fake_inject
authorMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 12 Jun 2012 13:55:57 +0000 (10:55 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 27 Jun 2012 12:01:30 +0000 (09:01 -0300)
In order to test if the error counters are properly incremented,
add a way to specify how many errors were generated by a trace.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/edac/edac_mc_sysfs.c
include/linux/edac.h

index a2bf7e9dd6dee7b43e1095effdca33554e9ceb9f..ed0bc07b85039deb78c09812e461e0c41e3b3670 100644 (file)
@@ -812,18 +812,24 @@ static ssize_t edac_fake_inject_write(struct file *file,
        struct device *dev = file->private_data;
        struct mem_ctl_info *mci = to_mci(dev);
        static enum hw_event_mc_err_type type;
+       u16 errcount = mci->fake_inject_count;
+
+       if (!errcount)
+               errcount = 1;
 
        type = mci->fake_inject_ue ? HW_EVENT_ERR_UNCORRECTED
                                   : HW_EVENT_ERR_CORRECTED;
 
        printk(KERN_DEBUG
-              "Generating a %s fake error to %d.%d.%d to test core handling. NOTE: this won't test the driver-specific decoding logic.\n",
+              "Generating %d %s fake error%s to %d.%d.%d to test core handling. NOTE: this won't test the driver-specific decoding logic.\n",
+               errcount,
                (type == HW_EVENT_ERR_UNCORRECTED) ? "UE" : "CE",
+               errcount > 1 ? "s" : "",
                mci->fake_inject_layer[0],
                mci->fake_inject_layer[1],
                mci->fake_inject_layer[2]
               );
-       edac_mc_handle_error(type, mci, 1, 0, 0, 0,
+       edac_mc_handle_error(type, mci, errcount, 0, 0, 0,
                             mci->fake_inject_layer[0],
                             mci->fake_inject_layer[1],
                             mci->fake_inject_layer[2],
@@ -944,6 +950,11 @@ int edac_create_debug_nodes(struct mem_ctl_info *mci)
        if (!d)
                goto nomem;
 
+       d = debugfs_create_u16("fake_inject_count", S_IRUGO | S_IWUSR, parent,
+                               &mci->fake_inject_count);
+       if (!d)
+               goto nomem;
+
        d = debugfs_create_file("fake_inject", S_IWUSR, parent,
                                &mci->dev,
                                &debug_fake_inject_fops);
index 6677af853e30d209a7e63f91c637d73ffa8eb6a1..bab9f8473dc1c7673c7e900e73691d38ee35e737 100644 (file)
@@ -665,6 +665,7 @@ struct mem_ctl_info {
        struct dentry *debugfs;
        u8 fake_inject_layer[EDAC_MAX_LAYERS];
        u32 fake_inject_ue;
+       u16 fake_inject_count;
 #endif
 };