Don't leave priv->image dangling when use-stock is set to FALSE. (#437281,

2007-07-03  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkbutton.c (gtk_button_construct_child): Don't leave
        priv->image dangling when use-stock is set to FALSE.  (#437281,
        Jochen Baier)

svn path=/trunk/; revision=18362

diff --git a/ChangeLog b/ChangeLog
index 88c3965c75a817952ce0c14cce14fa0780ec9e3c..d28db1f463e4775ffc87474b679dde3701e40177 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2007-07-03  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtkbutton.c (gtk_button_construct_child): Don't leave
+       priv->image dangling when use-stock is set to FALSE.  (#437281,
+       Jochen Baier)
+
 2007-07-03  Tor Lillqvist  <tml@novell.com>
 
        * configure.in: Handle GDK_PIXBUF_EXTRA_LIBS like GDK_EXTRA_LIBS,

diff --git a/gtk/gtkbutton.c b/gtk/gtkbutton.c
index 1b7db3921f92389b6316d22718d37c00a3b437ff..00216899ccdde5001e3a746cc23608ded0f57791 100644 (file)
--- a/gtk/gtkbutton.c
+++ b/gtk/gtkbutton.c
@@ -733,14 +733,14 @@ gtk_button_construct_child (GtkButton *button)
       image = g_object_ref (priv->image);
       if (image->parent)
        gtk_container_remove (GTK_CONTAINER (image->parent), image);
-
-      priv->image = NULL;
     }
   
+  priv->image = NULL;
+
   if (GTK_BIN (button)->child)
     gtk_container_remove (GTK_CONTAINER (button),
                          GTK_BIN (button)->child);
-  
+
   if (button->use_stock &&
       button->label_text &&
       gtk_stock_lookup (button->label_text, &item))