]> Pileus Git - ~andy/linux/commitdiff
x86/process: Change %8s to %s for pr_warn() in release_thread()
authorChen Gang <gang.chen@asianux.com>
Tue, 6 Nov 2012 06:45:46 +0000 (14:45 +0800)
committerIngo Molnar <mingo@kernel.org>
Thu, 24 Jan 2013 17:11:03 +0000 (18:11 +0100)
the length of dead_task->comm[] is 16 (TASK_COMM_LEN)
on pr_warn(), it is not meaningful to use %8s for task->comm[].

So change it to %s, since the line is not solid anyway.

Additional information:

 %8s  limit the width, not for the original string output length
      if name length is more than 8, it still can be fully displayed.
      if name length is less than 8, the ' ' will be filled before name.

 %.8s truly limit the original string output length (precision)

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Link: http://lkml.kernel.org/n/tip-nridm1zvreai1tgfLjuexDmd@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/process_64.c

index 6e68a6194965d66f07de49245bb177bb7e1f1cb7..0f49677da51e62afe9b14f6967ded036e098a578 100644 (file)
@@ -117,7 +117,7 @@ void release_thread(struct task_struct *dead_task)
 {
        if (dead_task->mm) {
                if (dead_task->mm->context.size) {
-                       pr_warn("WARNING: dead process %8s still has LDT? <%p/%d>\n",
+                       pr_warn("WARNING: dead process %s still has LDT? <%p/%d>\n",
                                dead_task->comm,
                                dead_task->mm->context.ldt,
                                dead_task->mm->context.size);