]> Pileus Git - ~andy/linux/commitdiff
OMAPDSS: APPLY: remove dssdev from dss_mgr_wait_for_vsync
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 15 Feb 2013 12:24:38 +0000 (14:24 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 3 Apr 2013 12:19:00 +0000 (15:19 +0300)
dss_mgr_wait_for_vsync() uses dssdev->type to find out if the output is
going to VENC, HDMI, or something else. This creates a dependency on
dssdev, which we want to remove. The task is more logically done by
looking at the output to which the overlay manager in question is
connected to.

This patch changes the code to use output->id to find out which kind of
output we use.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Archit Taneja <archit@ti.com>
drivers/video/omap2/dss/apply.c

index d446bdfc4c821fc4a26caf401716cc843cef370a..a4b356a9780d305f37673743f40eb5cbe61942a9 100644 (file)
@@ -435,20 +435,27 @@ static inline struct omap_dss_device *dss_mgr_get_device(struct omap_overlay_man
 static int dss_mgr_wait_for_vsync(struct omap_overlay_manager *mgr)
 {
        unsigned long timeout = msecs_to_jiffies(500);
-       struct omap_dss_device *dssdev = mgr->get_device(mgr);
        u32 irq;
        int r;
 
+       if (mgr->output == NULL)
+               return -ENODEV;
+
        r = dispc_runtime_get();
        if (r)
                return r;
 
-       if (dssdev->type == OMAP_DISPLAY_TYPE_VENC)
+       switch (mgr->output->id) {
+       case OMAP_DSS_OUTPUT_VENC:
                irq = DISPC_IRQ_EVSYNC_ODD;
-       else if (dssdev->type == OMAP_DISPLAY_TYPE_HDMI)
+               break;
+       case OMAP_DSS_OUTPUT_HDMI:
                irq = DISPC_IRQ_EVSYNC_EVEN;
-       else
+               break;
+       default:
                irq = dispc_mgr_get_vsync_irq(mgr->id);
+               break;
+       }
 
        r = omap_dispc_wait_for_irq_interruptible_timeout(irq, timeout);