set_boxed will copy the color and will use a mem_chunk to do it. Avoid an

2002-01-13  Jody Goldberg <jody@gnome.org>

        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
	  and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
	  leak, and confusion.

diff --git a/ChangeLog b/ChangeLog
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index b7863283626ef5071feccfde1bbc924fc25c6322..3ade382500e405484eef4977228a61ba5db9698f 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -92,6 +92,12 @@ Mon Jan 14 16:35:58 2002  Owen Taylor  <otaylor@redhat.com>
        * gtk/gtkwindow.c (gtk_window_move_resize): Unset 
        initial_pos_set after the first configure request.
 
+2002-01-13  Jody Goldberg <jody@gnome.org>
+
+        * gtk/gtktexttag.c (get_color_arg) : set_boxed will copy the color
+         and will use a mem_chunk to do it.  Avoid an unnecessary copy, a
+         leak, and confusion.
+
 Sun Jan 13 23:23:22 2002  Owen Taylor  <otaylor@redhat.com>
 
        * gtk/gtkwindow.c (gtk_window_compute_hints): Fix problem where

diff --git a/gtk/gtktexttag.c b/gtk/gtktexttag.c
index 8899451c00f42dbd019c205e44b6df29581310ea..7000d88b553901975346aaa61ba4b17d81dd3de5 100644 (file)
--- a/gtk/gtktexttag.c
+++ b/gtk/gtktexttag.c
@@ -1358,12 +1358,8 @@ gtk_text_tag_set_property (GObject      *object,
 static void
 get_color_arg (GValue *value, GdkColor *orig)
 {
-  GdkColor *color;
-
-  color = g_new (GdkColor, 1);
-  *color = *orig;
   g_value_init (value, GDK_TYPE_COLOR);
-  g_value_set_boxed (value, color);
+  g_value_set_boxed (value, orig);
 }
 
 static void