Random debugging fixed this bug: There is no need to set the ExposureMask

1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>

	* gdk/gdk.c (gdk_event_translate): Random debugging fixed this
	bug:  There is no need to set the ExposureMask in the XGrabPointer
	(this caused DnD programs to crash).

diff --git a/ChangeLog b/ChangeLog
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index f064fb9855118966e0bb3616194e78901bc240c4..becc9e9dabb679879159727c91a6ee11a988b219 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,9 @@
+1998-04-28  Miguel de Icaza  <miguel@nuclecu.unam.mx>
+
+       * gdk/gdk.c (gdk_event_translate): Random debugging fixed this
+       bug:  There is no need to set the ExposureMask in the XGrabPointer
+       (this caused DnD programs to crash).
+
 Fri Apr 24 01:29:04 1998  Tim Janik  <timj@gtk.org>
 
        * gtk/gtkaccelerator.h (struct _GtkAcceleratorTable): changed ref_count

diff --git a/gdk/gdk.c b/gdk/gdk.c
index 9cd94cee7268a496a2178a7595be76532534a40f..30b11087b0827672887eab01d8e0f26d93255054 100644 (file)
--- a/gdk/gdk.c
+++ b/gdk/gdk.c
@@ -2329,11 +2329,11 @@ gdk_event_translate (GdkEvent *event,
          gdk_dnd_drag_addwindow((GdkWindow *) gdk_dnd.real_sw);
          gdk_dnd_drag_begin((GdkWindow *) gdk_dnd.real_sw);
          xgpret = 
-         XGrabPointer(gdk_display, gdk_dnd.real_sw->xwindow, False,
+         XGrabPointer(gdk_display, gdk_dnd.real_sw->xwindow, True,
                       ButtonMotionMask | PointerMotionMask |
                       /* PointerMotionHintMask | */ /* HINTME */
-                      ButtonPressMask | ButtonReleaseMask | ExposureMask,
-                      GrabModeAsync, GrabModeAsync, gdk_root_window,
+                      ButtonPressMask | ButtonReleaseMask,
+                      GrabModeAsync, GrabModeAsync, None,
                       None, CurrentTime);
 #ifdef G_ENABLE_DEBUG
          GDK_NOTE(DND, g_print("xgpret = %d\n", xgpret));

diff --git a/gdk/x11/gdkmain-x11.c b/gdk/x11/gdkmain-x11.c
index 9cd94cee7268a496a2178a7595be76532534a40f..30b11087b0827672887eab01d8e0f26d93255054 100644 (file)
--- a/gdk/x11/gdkmain-x11.c
+++ b/gdk/x11/gdkmain-x11.c
@@ -2329,11 +2329,11 @@ gdk_event_translate (GdkEvent *event,
          gdk_dnd_drag_addwindow((GdkWindow *) gdk_dnd.real_sw);
          gdk_dnd_drag_begin((GdkWindow *) gdk_dnd.real_sw);
          xgpret = 
-         XGrabPointer(gdk_display, gdk_dnd.real_sw->xwindow, False,
+         XGrabPointer(gdk_display, gdk_dnd.real_sw->xwindow, True,
                       ButtonMotionMask | PointerMotionMask |
                       /* PointerMotionHintMask | */ /* HINTME */
-                      ButtonPressMask | ButtonReleaseMask | ExposureMask,
-                      GrabModeAsync, GrabModeAsync, gdk_root_window,
+                      ButtonPressMask | ButtonReleaseMask,
+                      GrabModeAsync, GrabModeAsync, None,
                       None, CurrentTime);
 #ifdef G_ENABLE_DEBUG
          GDK_NOTE(DND, g_print("xgpret = %d\n", xgpret));