]> Pileus Git - ~andy/linux/commitdiff
[media] s5p-fimc: Use switch statement for better readability
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Tue, 24 Jul 2012 15:06:26 +0000 (12:06 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 30 Jul 2012 22:23:17 +0000 (19:23 -0300)
Use switch statement rather than multiple 'else if'.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/s5p-fimc/fimc-reg.c

index 74a2fba2c5437dc15f21589f955114c86580e530..0e3eb9ce4f981857a805e80fed82629fd4c88100 100644 (file)
@@ -667,7 +667,8 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc,
                FIMC_REG_CIGCTRL_SELCAM_MIPI | FIMC_REG_CIGCTRL_CAMIF_SELWB |
                FIMC_REG_CIGCTRL_SELCAM_MIPI_A | FIMC_REG_CIGCTRL_CAM_JPEG);
 
-       if (cam->bus_type == FIMC_MIPI_CSI2) {
+       switch (cam->bus_type) {
+       case FIMC_MIPI_CSI2:
                cfg |= FIMC_REG_CIGCTRL_SELCAM_MIPI;
 
                if (cam->mux_id == 0)
@@ -691,14 +692,15 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc,
                tmp |= (csis_data_alignment == 32) << 8;
 
                writel(tmp, fimc->regs + FIMC_REG_CSIIMGFMT);
-
-       } else if (cam->bus_type == FIMC_ITU_601 ||
-                  cam->bus_type == FIMC_ITU_656) {
+               break;
+       case FIMC_ITU_601...FIMC_ITU_656:
                if (cam->mux_id == 0) /* ITU-A, ITU-B: 0, 1 */
                        cfg |= FIMC_REG_CIGCTRL_SELCAM_ITU_A;
-       } else if (cam->bus_type == FIMC_LCD_WB) {
+               break;
+       case FIMC_LCD_WB:
                cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB;
-       } else {
+               break;
+       default:
                v4l2_err(vid_cap->vfd, "Invalid camera bus type selected\n");
                return -EINVAL;
        }