]> Pileus Git - ~andy/linux/commitdiff
serial: sh-sci: Regtype probing doesn't need to be fatal.
authorPaul Mundt <lethal@linux-sh.org>
Tue, 28 Jun 2011 04:44:37 +0000 (13:44 +0900)
committerPaul Mundt <lethal@linux-sh.org>
Tue, 28 Jun 2011 04:44:37 +0000 (13:44 +0900)
This was using a BUG_ON(), but it's not strictly necessary, so relax the
constraints a bit.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>
drivers/tty/serial/sh-sci.c

index 8e55e0a2733a6fdc749d8c8ef0b9a413e507316d..5ff6657fd141b4e737173ce08b183c49872f5f8f 100644 (file)
@@ -1825,6 +1825,7 @@ static int __devinit sci_init_single(struct platform_device *dev,
                                     struct plat_sci_port *p)
 {
        struct uart_port *port = &sci_port->port;
+       int ret;
 
        port->ops       = &sci_uart_ops;
        port->iotype    = UPIO_MEM;
@@ -1845,8 +1846,11 @@ static int __devinit sci_init_single(struct platform_device *dev,
                break;
        }
 
-       if (p->regtype == SCIx_PROBE_REGTYPE)
-               BUG_ON(sci_probe_regmap(p) != 0);
+       if (p->regtype == SCIx_PROBE_REGTYPE) {
+               ret = sci_probe_regmap(p);
+               if (unlikely(!ret))
+                       return ret;
+       }
 
        if (dev) {
                sci_port->iclk = clk_get(&dev->dev, "sci_ick");