]> Pileus Git - ~andy/linux/commitdiff
rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
authorDevendra.Naga <devendra.aaru@gmail.com>
Tue, 31 Jan 2012 07:11:03 +0000 (02:11 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 22 Feb 2012 19:47:37 +0000 (14:47 -0500)
in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask
is AND with 1 and compared against 1. i.e.
       if ((bitmask >> i) & 0x1 == 1)
               break;
which in the if condition is anyway becomes a 1 or 0.

Signed-off-by: Devendra.Naga <devendra.aaru@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c

index 22e998dd2f32beddc8ab1a3c9590e87b053de5e6..a76b22387e3de7afa970841a5f95577557c74b57 100644 (file)
@@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
        u32 i;
 
        for (i = 0; i <= 31; i++) {
-               if (((bitmask >> i) & 0x1) == 1)
+               if ((bitmask >> i) & 0x1)
                        break;
        }
        return i;