]> Pileus Git - ~andy/gtk/commitdiff
[filechooser] Don't add extra ref to file, as it it comes from gtk_tree_model_get()
authorFederico Mena Quintero <federico@gnome.org>
Fri, 1 Apr 2011 18:44:10 +0000 (12:44 -0600)
committerFederico Mena Quintero <federico@gnome.org>
Fri, 1 Apr 2011 23:00:16 +0000 (17:00 -0600)
Leak kindly reported by leak finder extraordinaire Morten Welinder <mortenw@gnome.org>

https://bugzilla.gnome.org/show_bug.cgi?id=646457

gtk/gtkfilechooserdefault.c

index 9c6c7177394bd8ae68bf44dfeb3b622b67646fb2..849bd7321d9ba9ec9efd44ae8e3ef8fd84958914 100644 (file)
@@ -8732,7 +8732,7 @@ search_selected_foreach_get_file_cb (GtkTreeModel *model,
   list = data;
 
   gtk_tree_model_get (model, iter, MODEL_COL_FILE, &file, -1);
-  *list = g_slist_prepend (*list, g_object_ref (file));
+  *list = g_slist_prepend (*list, file); /* The file already has a new ref courtesy of gtk_tree_model_get(); this will be unreffed by the caller */
 }
 
 /* Constructs a list of the selected paths in search mode */