]> Pileus Git - ~andy/linux/commitdiff
driver: tty: add missing unregister in err case
authorLibo Chen <clbchenlibo.chen@huawei.com>
Wed, 29 May 2013 02:33:16 +0000 (10:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2013 17:30:43 +0000 (10:30 -0700)
when platform_driver_register broken, we should unregister ucc_uart_driver

Signed-off-by: Libo chen <libo.chen@huawei.com>
Acked-by: Timur Tabi <timur@tabi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/ucc_uart.c

index c8ab8e45e1b973213fb4e2d8e1f720c666906847..88317482b81fce4929dc2556e1b19358c6156017 100644 (file)
@@ -1517,9 +1517,11 @@ static int __init ucc_uart_init(void)
        }
 
        ret = platform_driver_register(&ucc_uart_of_driver);
-       if (ret)
+       if (ret) {
                printk(KERN_ERR
                       "ucc-uart: could not register platform driver\n");
+               uart_unregister_driver(&ucc_uart_driver);
+       }
 
        return ret;
 }