]> Pileus Git - ~andy/linux/commitdiff
mm: page-writeback.c: local functions should not be exposed globally
authorH Hartley Sweeten <hartleys@visionengravers.com>
Thu, 12 Apr 2012 20:44:20 +0000 (13:44 -0700)
committerFengguang Wu <fengguang.wu@intel.com>
Sat, 14 Apr 2012 09:37:27 +0000 (17:37 +0800)
The function global_dirtyable_memory is only referenced in this file and
should be marked static to prevent it from being exposed globally.

This quiets the sparse warning:

warning: symbol 'global_dirtyable_memory' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
mm/page-writeback.c

index 26adea8ca2e7dd9ebdbc9c0938498a1a8a56324d..9dec97fee3750d1772df78948d37377a95ff231c 100644 (file)
@@ -204,7 +204,7 @@ static unsigned long highmem_dirtyable_memory(unsigned long total)
  * Returns the global number of pages potentially available for dirty
  * page cache.  This is the base value for the global dirty limits.
  */
-unsigned long global_dirtyable_memory(void)
+static unsigned long global_dirtyable_memory(void)
 {
        unsigned long x;