]> Pileus Git - ~andy/linux/commitdiff
ASoC: nuc900: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 6 Jan 2014 13:19:13 +0000 (14:19 +0100)
committerMark Brown <broonie@linaro.org>
Thu, 9 Jan 2014 14:29:02 +0000 (14:29 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/nuc900/nuc900-pcm.c

index f588ee45b4fdd610d21c316f469b81b687da40a9..f434ed79d1b613bc64470cfa3041f4808b237f47 100644 (file)
@@ -32,9 +32,6 @@ static const struct snd_pcm_hardware nuc900_pcm_hardware = {
                                        SNDRV_PCM_INFO_MMAP_VALID |
                                        SNDRV_PCM_INFO_PAUSE |
                                        SNDRV_PCM_INFO_RESUME,
-       .formats                = SNDRV_PCM_FMTBIT_S16_LE,
-       .channels_min           = 1,
-       .channels_max           = 2,
        .buffer_bytes_max       = 4*1024,
        .period_bytes_min       = 1*1024,
        .period_bytes_max       = 4*1024,