Small optimization

diff --git a/ChangeLog b/ChangeLog
index 697a31da55744def9a2da26c1b6072c3cbc49362..e11f54691052c38d3ddf455268e3a90ca764402c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-03-26  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtkcellrenderertext.c (gtk_cell_render_text_get_property):
+       Avoid an unnecessary strdup.  (#336013)
+
 2006-03-24  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtktextview.c (gtk_text_view_value_changed): Don't call

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 697a31da55744def9a2da26c1b6072c3cbc49362..e11f54691052c38d3ddf455268e3a90ca764402c 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+2006-03-26  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtk/gtkcellrenderertext.c (gtk_cell_render_text_get_property):
+       Avoid an unnecessary strdup.  (#336013)
+
 2006-03-24  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtktextview.c (gtk_text_view_value_changed): Don't call

diff --git a/gtk/gtkcellrenderertext.c b/gtk/gtkcellrenderertext.c
index 2ff8c52586bbcb6dec56702ff23c229e1e321191..a5aca6e1926d6dadb11cb0882398cff16fd7ac22 100644 (file)
--- a/gtk/gtkcellrenderertext.c
+++ b/gtk/gtkcellrenderertext.c
@@ -689,14 +689,7 @@ gtk_cell_renderer_text_get_property (GObject        *object,
       break;
 
     case PROP_FONT:
-      {
-        /* FIXME GValue imposes a totally gratuitous string copy
-         * here, we could just hand off string ownership
-         */
-        gchar *str = pango_font_description_to_string (celltext->font);
-        g_value_set_string (value, str);
-        g_free (str);
-      }
+        g_value_take_string (value, pango_font_description_to_string (celltext->font);
       break;
       
     case PROP_FONT_DESC: