]> Pileus Git - ~andy/linux/commitdiff
rtc: rtc-m41t93: use devm_rtc_device_register()
authorJingoo Han <jg1.han@samsung.com>
Mon, 29 Apr 2013 23:19:40 +0000 (16:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 30 Apr 2013 01:28:30 +0000 (18:28 -0700)
devm_rtc_device_register() is device managed and makes cleanup paths
simpler.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-m41t93.c

index 49169680786e5005a4154befca38ba8dd2decdba..cfc21a1608ab1b37d91e00f54d01f48c8947084d 100644 (file)
@@ -184,8 +184,8 @@ static int m41t93_probe(struct spi_device *spi)
                return -ENODEV;
        }
 
-       rtc = rtc_device_register(m41t93_driver.driver.name,
-               &spi->dev, &m41t93_rtc_ops, THIS_MODULE);
+       rtc = devm_rtc_device_register(&spi->dev, m41t93_driver.driver.name,
+                                       &m41t93_rtc_ops, THIS_MODULE);
        if (IS_ERR(rtc))
                return PTR_ERR(rtc);
 
@@ -197,11 +197,6 @@ static int m41t93_probe(struct spi_device *spi)
 
 static int m41t93_remove(struct spi_device *spi)
 {
-       struct rtc_device *rtc = spi_get_drvdata(spi);
-
-       if (rtc)
-               rtc_device_unregister(rtc);
-
        return 0;
 }