Fixes most cases of initializing a var but not using it.
There are still 3 cases at em28xx-alsa, were those vars should
probably be used.
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
runtime->hw = snd_em28xx_hw_capture;
if (dev->alt == 0 && dev->adev.users == 0) {
runtime->hw = snd_em28xx_hw_capture;
if (dev->alt == 0 && dev->adev.users == 0) {
dev->alt = 7;
dprintk("changing alternate number to 7\n");
dev->alt = 7;
dprintk("changing alternate number to 7\n");
- errCode = usb_set_interface(dev->udev, 0, 7);
+ usb_set_interface(dev->udev, 0, 7);
ret = snd_pcm_alloc_vmalloc_buffer(substream,
params_buffer_bytes(hw_params));
ret = snd_pcm_alloc_vmalloc_buffer(substream,
params_buffer_bytes(hw_params));
+ if (ret < 0)
+ return ret;
format = params_format(hw_params);
rate = params_rate(hw_params);
channels = params_channels(hw_params);
format = params_format(hw_params);
rate = params_rate(hw_params);
channels = params_channels(hw_params);
int cmd)
{
struct em28xx *dev = snd_pcm_substream_chip(substream);
int cmd)
{
struct em28xx *dev = snd_pcm_substream_chip(substream);
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
retval = -EINVAL;
}
schedule_work(&dev->wq_trigger);
retval = -EINVAL;
}
schedule_work(&dev->wq_trigger);
}
static snd_pcm_uframes_t snd_em28xx_capture_pointer(struct snd_pcm_substream
}
static snd_pcm_uframes_t snd_em28xx_capture_pointer(struct snd_pcm_substream
.addr = 0xba >> 1,
.platform_data = &pdata,
};
.addr = 0xba >> 1,
.platform_data = &pdata,
};
- struct v4l2_subdev *sd;
pdata.xtal = dev->sensor_xtal;
pdata.xtal = dev->sensor_xtal;
- sd = v4l2_i2c_new_subdev_board(&dev->v4l2_dev, &dev->i2c_adap,
+ v4l2_i2c_new_subdev_board(&dev->v4l2_dev, &dev->i2c_adap,
static void em28xx_irq_callback(struct urb *urb)
{
struct em28xx *dev = urb->context;
static void em28xx_irq_callback(struct urb *urb)
{
struct em28xx *dev = urb->context;
switch (urb->status) {
case 0: /* success */
switch (urb->status) {
case 0: /* success */
/* Copy data from URB */
spin_lock(&dev->slock);
/* Copy data from URB */
spin_lock(&dev->slock);
- rc = dev->isoc_ctl.isoc_copy(dev, urb);
+ dev->isoc_ctl.isoc_copy(dev, urb);
spin_unlock(&dev->slock);
/* Reset urb buffers */
spin_unlock(&dev->slock);
/* Reset urb buffers */
*/
static int em28xx_i2c_check_for_device(struct em28xx *dev, unsigned char addr)
{
*/
static int em28xx_i2c_check_for_device(struct em28xx *dev, unsigned char addr)
{
ret = dev->em28xx_read_reg_req(dev, 2, addr);
if (ret < 0) {
ret = dev->em28xx_read_reg_req(dev, 2, addr);
if (ret < 0) {