]> Pileus Git - ~andy/linux/commit
Btrfs: fix snprintf usage by send's gen_unique_name
authorFilipe David Borba Manana <fdmanana@gmail.com>
Tue, 21 Jan 2014 23:36:38 +0000 (23:36 +0000)
committerChris Mason <clm@fb.com>
Tue, 28 Jan 2014 21:20:43 +0000 (13:20 -0800)
commitf74b86d85533a98ef7f573487af38f9dd514becb
tree86ad2a4b8d7d39076c0df8789040ae0bc82287bf
parentc41570c9d29764f797fa35490d72b7395a0105c3
Btrfs: fix snprintf usage by send's gen_unique_name

The buffer size argument passed to snprintf must account for the
trailing null byte added by snprintf, and it returns a value >= then
sizeof(buffer) when the string can't fit in the buffer.

Since our buffer has a size of 64 characters, and the maximum orphan
name we can generate is 63 characters wide, we must pass 64 as the
buffer size to snprintf, and not 63.

Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/send.c