]> Pileus Git - ~andy/linux/commit
drm/i915: Fix disabled semaphores
authorBen Widawsky <benjamin.widawsky@intel.com>
Wed, 18 Dec 2013 04:06:00 +0000 (20:06 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 22 Jan 2014 08:58:26 +0000 (09:58 +0100)
commitf0a9f74c0d735bc1b5a2811fe73c99604394374e
treed9cacf6c1c9dfb376fe41a7cb0316b26dcf141dd
parent8b78f0e588e22c3d5a8cd3ac260023ae7f942828
drm/i915: Fix disabled semaphores

The ring will emit too many if semaphores are disabled since we do not
add the correct number to num_dwords anymore.

This was introduced:
commit 52ed23253b68e1cf154b03d91bed619504cf955b
Author: Ben Widawsky <benjamin.widawsky@intel.com>
Date:   Mon Dec 16 20:50:38 2013 -0800

    drm/i915: Don't emit mbox updates without semaphores

FWIW, the bug was fixed later in the series.

/me hangs head in shame.

Daniel: Also note that we should have merged the read-only semaphore
modparam before this patch.

Reported-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_ringbuffer.c