]> Pileus Git - ~andy/linux/commit
netfilter: nf_tables: fix potential oops when dumping sets
authorPatrick McHardy <kaber@trash.net>
Wed, 5 Feb 2014 15:03:35 +0000 (15:03 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 5 Feb 2014 23:04:15 +0000 (00:04 +0100)
commitec2c9935688fbd5eaa7c975e3e21562c3da77363
tree929fe5c28ed844898fec9226773c20a55748dcb1
parent53b70287ddf487a38b7cbf0a10db28f40714b799
netfilter: nf_tables: fix potential oops when dumping sets

Commit c9c8e48597 (netfilter: nf_tables: dump sets in all existing families)
changed nft_ctx_init_from_setattr() to only look up the address family if it
is not NFPROTO_UNSPEC. However if it is NFPROTO_UNSPEC and a table attribute
is given, nftables_afinfo_lookup() will dereference the NULL afi pointer.

Fix by checking for non-NULL afi and also move a check added by that commit
to the proper position.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c