]> Pileus Git - ~andy/linux/commit
uprobes: No need to re-check vma_address() in write_opcode()
authorOleg Nesterov <oleg@redhat.com>
Fri, 15 Jun 2012 15:43:47 +0000 (17:43 +0200)
committerIngo Molnar <mingo@kernel.org>
Sat, 16 Jun 2012 07:10:47 +0000 (09:10 +0200)
commiteb2bf57bee42c7565032f93adaa211e2c9fcc52c
tree98eb3ecffb5e8489b6a026788880e80f5f9a1a92
parentfc36f59565861af2e897225bc3782479a26c5d5a
uprobes: No need to re-check vma_address() in write_opcode()

write_opcode() is called by register_for_each_vma() and
uprobe_mmap() paths. In both cases the caller has already
verified this vaddr under mmap_sem, no need to re-check.

Note also that this check is wrong anyway, we should not
truncate loff_t returned by vma_address() if we do not trust
this mapping.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anton Arapov <anton@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120615154347.GA9604@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/uprobes.c