]> Pileus Git - ~andy/linux/commit
batman-adv: Fix endianness errors for network coding
authorMartin Hundebøll <martin@hundeboll.net>
Thu, 14 Mar 2013 20:30:21 +0000 (21:30 +0100)
committerAntonio Quartulli <ordex@autistici.org>
Wed, 27 Mar 2013 09:27:31 +0000 (10:27 +0100)
commite6a0b495ffee1301c239da49818008e7de3c2ae1
treec68ffc41df3776d6b767c8d927a0d6d85868a6ee
parent6bdeaba47d87f48a3943b6899d6c6e6f17d52f1d
batman-adv: Fix endianness errors for network coding

Add a htonl() in network_coding.c when reading the sequence number
from received ogm_packet, to avoid wrong byte ordering when comparing
with a host value. This bug was introduced in
3ed7ada3f0bbcd058567bc0a8f9729a73eba7db6 ("batman-adv: network coding -
detect coding nodes and remove these after timeout").

Change the type of coded_packet->coded_len from uint16 to __be16 to
avoid wrong assumptions about endianness in later uses. Introduced in
c3289f3650d34b60296000a629c99f2488f7c3dd ("batman-adv: network coding -
code and transmit packets if possible").

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
net/batman-adv/network-coding.c
net/batman-adv/packet.h