]> Pileus Git - ~andy/linux/commit
projects / ~andy / linux / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 027253c) | patch
drivers/ide/ide-cs.c: adjust suspicious bit operation
authorJulia Lawall <Julia.Lawall@lip6.fr>
Tue, 12 Jun 2012 14:17:25 +0000 (10:17 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Jun 2012 22:51:41 +0000 (15:51 -0700)
commite58c5de8f59d124907c993ea3126c69493b7eec7
tree9b4a4673cb7700431b8ded39304d9bf6bfba3afftree | snapshot
parent027253c138a12b075e724f94b6cc43fd7071c14fcommit | diff
drivers/ide/ide-cs.c: adjust suspicious bit operation

IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false.  The
value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
first pick those bits and then make the test using !=.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-cs.c diff | blob | history
Andy's Linux Kernel repo