]> Pileus Git - ~andy/linux/commit
[media] siano: remove the bogus firmware lookup code
authorMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 19 Mar 2013 15:00:23 +0000 (12:00 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Mar 2013 10:52:57 +0000 (07:52 -0300)
commite584f9d61ea0aefa81ddd3faf53100536ba4057e
treee3fc553dfa9fa583d26c7d799f0f2f8b9f63849c
parent9711a8a600a12d2895c18f31be1fc5b3c4d9b209
[media] siano: remove the bogus firmware lookup code

There is an special lookup code that is called when
SMS_BOARD_UNKNOWN. The logic there is bogus and will cause
an oops, as .type is SMS_UNKNOWN_TYPE (-1).
As the code would do:
return smscore_fw_lkup[type][mode];
That would mean that it would try to go past the
smscore_fw_lkup table.
So, just remove that bogus code, simplifying the logic.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/common/siano/smscoreapi.c