]> Pileus Git - ~andy/linux/commit
ceph: don't set WRITE_PENDING too early
authorAlex Elder <elder@inktank.com>
Wed, 16 May 2012 20:16:38 +0000 (15:16 -0500)
committerAlex Elder <elder@dreamhost.com>
Thu, 17 May 2012 13:18:12 +0000 (08:18 -0500)
commite10c758e4031a801ea4d2f8fb39bf14c2658d74b
treedb67e6d84e5fa76b4d573d4f551019141115af01
parente825a66df97776d30a48a187e3a986736af43945
ceph: don't set WRITE_PENDING too early

prepare_write_connect() prepares a connect message, then sets
WRITE_PENDING on the connection.  Then *after* this, it calls
prepare_connect_authorizer(), which updates the content of the
connection buffer already queued for sending.  It's also possible it
will result in prepare_write_connect() returning -EAGAIN despite the
WRITE_PENDING big getting set.

Fix this by preparing the connect authorizer first, setting the
WRITE_PENDING bit only after that is done.

Partially addresses http://tracker.newdream.net/issues/2424

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
net/ceph/messenger.c