]> Pileus Git - ~andy/linux/commit
mac80211: fix duplicate retransmission detection
authorJohannes Berg <johannes.berg@intel.com>
Thu, 11 Jul 2013 20:33:26 +0000 (22:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Aug 2013 22:38:22 +0000 (15:38 -0700)
commitd8605bdee3179b21d4467dc5077ffe39ae5a175c
treeb622e73fd9cf4866bc6a56700071ea26b28cfc75
parent8c35e86a798694d5741b2b71c29053fb2b6cd56c
mac80211: fix duplicate retransmission detection

commit 6b0f32745dcfba01d7be33acd1b40306c7a914c6 upstream.

The duplicate retransmission detection code in mac80211
erroneously attempts to do the check for every frame,
even frames that don't have a sequence control field or
that don't use it (QoS-Null frames.)

This is problematic because it causes the code to access
data beyond the end of the SKB and depending on the data
there will drop packets erroneously.

Correct the code to not do duplicate detection for such
frames.

I found this error while testing AP powersave, it lead
to retransmitted PS-Poll frames being dropped entirely
as the data beyond the end of the SKB was always zero.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mac80211/rx.c