]> Pileus Git - ~andy/linux/commit
tracing: Do not assign filp->private_data to freed memory
authorGeyslan G. Bem <geyslan@gmail.com>
Wed, 6 Nov 2013 19:02:51 +0000 (16:02 -0300)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 6 Nov 2013 20:26:54 +0000 (15:26 -0500)
commitd6d3523caab75196560c85aae80cb8f4a8e380ea
treec051e62d5e1579a530ed2966d1ee38f5c7a8dce8
parent2e86421debc2cf4d1513c9b73fcd34c5ce431ae3
tracing: Do not assign filp->private_data to freed memory

In system_tr_open(), the filp->private_data can be assigned the 'dir'
variable even if it was freed. This is on the error path, and is
harmless because the error return code will prevent filp->private_data
from being used. But for correctness, we should not assign it to
a recently freed variable, as that can cause static tools to give
false warnings.

Also have both subsystem_open() and system_tr_open() return -ENODEV
if tracing has been disabled.

Link: http://lkml.kernel.org/r/1383764571-7318-1-git-send-email-geyslan@gmail.com
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_events.c