]> Pileus Git - ~andy/linux/commit
net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()
authorDaniel Mack <zonque@gmail.com>
Tue, 12 Mar 2013 06:31:19 +0000 (06:31 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Mar 2013 08:47:18 +0000 (04:47 -0400)
commitd35162f89b8f00537d7b240b76d2d0e8b8d29aa0
tree115ab859c528b0a5bf51296528f5006de009e99f
parentc80a8512ee3a8e1f7c3704140ea55f21dc6bd651
net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc()

Commit fae50823d0 ("net: ethernet: davinci_cpdma: Add boundary for rx
and tx descriptors") introduced a function to check the current
allocation state of tx packets. The return value is taken into account
to stop the netqork queue on the adapter in case there are no free
slots.

However, cpdma_check_free_tx_desc() returns 'true' if there is room in
the bitmap, not 'false', so the usage of the function is wrong.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Reported-by: Sven Neumann <s.neumann@raumfeld.com>
Reported-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Tested-by: Mugunthan V N <mugunthanvnm@ti.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Tested-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c