]> Pileus Git - ~andy/linux/commit
target: Use LIST_HEAD()/DEFINE_MUTEX() for static objects
authorRoland Dreier <roland@purestorage.com>
Thu, 12 Jan 2012 18:41:18 +0000 (10:41 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 25 Feb 2012 22:37:46 +0000 (14:37 -0800)
commitd0f474e501929acdbd116cca39ef083012f70f25
treece4db92ff234d82c3b61ff05404ed4ae41551770
parentd5b4a21b3dc116b477c1b1b493233a73aacbb440
target: Use LIST_HEAD()/DEFINE_MUTEX() for static objects

Instead of

   static struct list_head foo;
   static struct mutex bar;

   ...

   INIT_LIST_HEAD(&foo);
   mutex_init(&bar);

just do

   static LIST_HEAD(foo);
   static DEFINE_MUTEX(bar);

Also remove some superfluous struct list_head and spinlock_t
initialization calls where the variables are already defined using
macros that initialize them.

This saves a decent amount of compiled code too:

    add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-178 (-178)
    function                                     old     new   delta
    target_core_init_configfs                    898     850     -48
    core_scsi3_emulate_pro_preempt              1742    1683     -59
    iscsi_thread_set_init                        159      88     -71

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_tq.c
drivers/target/target_core_configfs.c
drivers/target/target_core_pr.c