]> Pileus Git - ~andy/linux/commit
Revert "of: Feed entire flattened device tree into the random pool"
authorGrant Likely <grant.likely@linaro.org>
Mon, 14 Oct 2013 11:46:04 +0000 (12:46 +0100)
committerGrant Likely <grant.likely@linaro.org>
Mon, 14 Oct 2013 11:46:04 +0000 (12:46 +0100)
commitb920ecc826eacf7ad7dfeabc0cf74a8b88e3b7f5
treeb862486bbbd8dea941b082de14fc8104643eb26b
parent444c91e5720cb5b825356e32c67c2c5184d1c09a
Revert "of: Feed entire flattened device tree into the random pool"

This reverts commit 109b6236294b53d8eaa50be7d9e9ad37079f5f7e.

Tim Bird expressed concern that this will have a bad effect on boot
time, and while simple tests have shown it to be okay with simple tree,
a device tree blob can potentially be quite large and
add_device_randomness() is not a fast function. Rather than do this for
all platforms unconditionally, I'm reverting this patch and would like
to see it revisited. Instead of feeding the entire tree into the random
pool, it would probably be appropriate to hash the tree and feed the
hash result into the pool. There really isn't a lot of randomness in a
device tree anyway. In the majority of cases only a handful of
properties are going to be different between machines with the same
baseboard.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/of/fdt.c