]> Pileus Git - ~andy/linux/commit
loopdev: ignore negative offset when calculate loop device size
authorGuo Chao <yan@linux.vnet.ibm.com>
Thu, 21 Feb 2013 23:16:50 +0000 (15:16 -0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 22 Feb 2013 09:43:22 +0000 (10:43 +0100)
commitb7a1da695f3fb33d093e6de20b1dfc238e3c9587
tree396c68e51b16414c20b4ae2c61a421ab7d1739c6
parentb1a6650406875b9097a032eed89af50682fe1160
loopdev: ignore negative offset when calculate loop device size

Negative offset may cause loop device size larger than backing file
size.

 $ fallocate -l 1M a
 $ losetup --offset 0xffffffffffff0000 /dev/loop0 a
 $ blockdev --getsize64 /dev/loop0
 1114112
 $ ls -l a
 -rw-r--r-- 1 root root 1048576 Jan 23 12:46 a
 $ cat /dev/loop0
 cat: /dev/loop0: Input/output error

It makes no sense to do that. Only apply offset when it's positive.

Fix a typo in the comment by the way.

Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Guo Chao <yan@linux.vnet.ibm.com>
Cc: M. Hindess <hindessm@uk.ibm.com>
Cc: Nikanth Karthikesan <knikanth@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c