]> Pileus Git - ~andy/linux/commit
typhoon: set_settings broken on big-endian
authorAl Viro <viro@ftp.linux.org.uk>
Fri, 21 Dec 2007 06:20:43 +0000 (06:20 +0000)
committerJeff Garzik <jeff@garzik.org>
Sun, 23 Dec 2007 03:53:05 +0000 (22:53 -0500)
commitb46281f9c5d6ab7b6e412e83f8c62cecf4ebbdfd
tree036d3829622cb10bbcc467e56598d70c1ae565de
parentfdcfd77c813ef7997a60856812805f4cfbeb6222
typhoon: set_settings broken on big-endian

One cpu_to_le16() too many when passing argument for TYPHOON_CMD_XCVR_SELECT;
we end up passing host-endian while the hardware expects little-endian.  The
other place doing that (typhoon_start_runtime()) does the right thing, so the
card will recover at the next ifconfig up/tx timeout/resume, which limits the
amount of mess, but still, WTF?

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/typhoon.c