]> Pileus Git - ~andy/linux/commit
perf session: Fix infinite loop on invalid perf.data file
authorNamhyung Kim <namhyung.kim@lge.com>
Mon, 30 Sep 2013 08:19:48 +0000 (17:19 +0900)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 4 Oct 2013 18:17:46 +0000 (15:17 -0300)
commitb314e5cfd11fd78545ce6c2be42646254390c1aa
tree9316fed404c26d55ae87ae6b68b4842e78c820b9
parent027a7e86a17fb2d172f4eb17cd6b0e9f139224fd
perf session: Fix infinite loop on invalid perf.data file

perf-record updates the header in the perf.data file at termination.
Without this update perf-report (and other processing built-ins) it
caused an infinite loop when perf report (or something like) called.

This is because the algorithm in __perf_session__process_events()
depends on the data_size which is read from file header.  Use file size
directly instead in this case to do the best-effort processing.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: David Ahern <dsahern@gmail.com>
Tested-by: Sonny Rao <sonnyrao@chromium.org>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sonny Rao <sonnyrao@chromium.org>
Link: http://lkml.kernel.org/r/1380529188-27193-1-git-send-email-namhyung@kernel.org
Signed-off-by: David Ahern <dsahern@gmail.com>
[ Reworded warning as per Ingo Molnar suggestion, replaces 'perf.data'
  with session->filename, to precisely identify the data file involved ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/header.c
tools/perf/util/session.c