]> Pileus Git - ~andy/linux/commit
drm/i915: rearrange vlv dp enable and pre_enable callbacks
authorJani Nikula <jani.nikula@intel.com>
Tue, 30 Jul 2013 09:20:30 +0000 (12:20 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 5 Aug 2013 17:04:03 +0000 (19:04 +0200)
commitab1f90f9662482021fddd0e7868005401f62866f
treea1a094afd7dbdf687d76bfb5e77eb2c294c8f834
parent0980a60fba7a9afa3259390e8af16b6ce486858a
drm/i915: rearrange vlv dp enable and pre_enable callbacks

VLV wants encoder enabling before the pipe is up. This is currently
achieved through calling the ->enable callback early, right after the
->pre_enable callback, in valleyview_crtc_enable(). This loses both the
distinction between ->pre_enable and ->enable on VLV and the possibility
to use a hook at the end of the modeset sequence.

Rearrange the DP callbacks to make it possible to move ->enable call
later. Basically do everything in ->pre_enable on VLV, and make ->enable
a NOP.

There should be no functional changes.

v2: Rebase.

v3: Explain why this is needed in the commit message (Chris).

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c