]> Pileus Git - ~andy/linux/commit
tipc: remove all enabled flags from all tipc components
authorYing Xue <ying.xue@windriver.com>
Thu, 20 Feb 2014 03:32:49 +0000 (11:32 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Feb 2014 05:00:15 +0000 (00:00 -0500)
commit9fe7ed474956944443eec57c5f75be12e10da84e
treedb26e8900f9967600d7d58633e3ef95071e8f991
parent7cce3b75682ff898c935c17d186983cbf3ed393e
tipc: remove all enabled flags from all tipc components

When tipc module is inserted, many tipc components are initialized
one by one. During the initialization period, if one of them is
failed, tipc_core_stop() will be called to stop all components
whatever corresponding components are created or not. To avoid to
release uncreated ones, relevant components have to add necessary
enabled flags indicating whether they are created or not.

But in the initialization stage, if one component is unsuccessfully
created, we will just destroy successfully created components before
the failed component instead of all components. All enabled flags
defined in components, in turn, become redundant. Additionally it's
also unnecessary to identify whether table.types is NULL in
tipc_nametbl_stop() because name stable has been definitely created
successfully when tipc_nametbl_stop() is called.

Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/core.c
net/tipc/name_table.c
net/tipc/netlink.c
net/tipc/ref.c
net/tipc/server.c
net/tipc/server.h
net/tipc/socket.c