]> Pileus Git - ~andy/linux/commit
PCI: Add global pci_lock_rescan_remove()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 10 Jan 2014 14:22:18 +0000 (15:22 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 14 Jan 2014 00:49:49 +0000 (17:49 -0700)
commit9d16947b75831acd317ab9a53e0e94d160731d33
tree6eeee1ae3a6864ceaae7ba60e7abc846f1acb0a9
parenta870614a5371f8e36676e9bb2e089f4121976135
PCI: Add global pci_lock_rescan_remove()

There are multiple PCI device addition and removal code paths that may be
run concurrently with the generic PCI bus rescan and device removal that
can be triggered via sysfs.  If that happens, it may lead to multiple
different, potentially dangerous race conditions.

The most straightforward way to address those problems is to run
the code in question under the same lock that is used by the
generic rescan/remove code in pci-sysfs.c.  To prepare for those
changes, move the definition of the global PCI remove/rescan lock
to probe.c and provide global wrappers, pci_lock_rescan_remove()
and pci_unlock_rescan_remove(), allowing drivers to manipulate
that lock.  Also provide pci_stop_and_remove_bus_device_locked()
for the callers of pci_stop_and_remove_bus_device() who only need
to hold the rescan/remove lock around it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pci-sysfs.c
drivers/pci/probe.c
drivers/pci/remove.c
include/linux/pci.h