]> Pileus Git - ~andy/linux/commit
mutexes: Give more informative mutex warning in the !lock->owner case
authorChuansheng Liu <chuansheng.liu@intel.com>
Wed, 4 Dec 2013 05:58:13 +0000 (13:58 +0800)
committerIngo Molnar <mingo@kernel.org>
Tue, 17 Dec 2013 14:35:10 +0000 (15:35 +0100)
commit91f30a17024ff0d8345e11228af33ee938b13426
tree283bc22529ed94d7e5f4611609eb935a75032c98
parentbb799d3b980eb803ca2da4a4eefbd9308f8d988a
mutexes: Give more informative mutex warning in the !lock->owner case

When mutex debugging is enabled and an imbalanced mutex_unlock()
is called, we get the following, slightly confusing warning:

  [  364.208284] DEBUG_LOCKS_WARN_ON(lock->owner != current)

But in that case the warning is due to an imbalanced mutex_unlock() call,
and the lock->owner is NULL - so the message is misleading.

So improve the message by testing for this case specifically:

   DEBUG_LOCKS_WARN_ON(!lock->owner)

Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/1386136693.3650.48.camel@cliu38-desktop-build
[ Improved the changelog, changed the patch to use !lock->owner consistently. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/locking/mutex-debug.c