]> Pileus Git - ~andy/linux/commit
uprobes: Remove insert_vm_struct()->uprobe_mmap()
authorOleg Nesterov <oleg@redhat.com>
Sun, 29 Jul 2012 18:22:38 +0000 (20:22 +0200)
committerIngo Molnar <mingo@kernel.org>
Mon, 30 Jul 2012 09:27:22 +0000 (11:27 +0200)
commit89133786f9408d53361874a8c784fff150fc7f7c
treecde422d462e963b5128ea4f103e77b2d806fdc9f
parent6dab3cc078e3da0d26534410bc9e018a17031d95
uprobes: Remove insert_vm_struct()->uprobe_mmap()

Remove insert_vm_struct()->uprobe_mmap(). It is not needed, nobody
except arch/ia64/kernel/perfmon.c uses insert_vm_struct(vma)
with vma->vm_file != NULL.

And it is wrong. Again, get_user_pages() can not succeed before
vma_link(vma) makes is visible to find_vma(). And even if this
worked, we must not insert the new bp before this mapping is
visible to vma_prio_tree_foreach() for uprobe_unregister().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar.vnet.ibm.com>
Cc: Anton Arapov <anton@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20120729182238.GA20349@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
mm/mmap.c