]> Pileus Git - ~andy/linux/commit
projects / ~andy / linux / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 04d5821) | patch
bonding: fix a buffer overflow in bonding_show_queue_id.
authorNicolas de Pesloüan <nicolas.2p.debian@free.fr>
Thu, 15 Jul 2010 01:24:54 +0000 (18:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 15 Jul 2010 01:24:54 +0000 (18:24 -0700)
commit79236680bde29913dc6bfaf9165973b74223d5f7
treea34d509c3afa9596e02af63c54d407b4fd8266b1tree | snapshot
parent04d5821fa506551afbc072456fecee7b34b2977dcommit | diff
bonding: fix a buffer overflow in bonding_show_queue_id.

The test for buffer overflow ensures we have room for 6 more bytes.
sprintf, called with %s:%d, slave->dev->name, slave->queue_id may yield
far more than 6 bytes.

The correct test is res > (PAGE_SIZE - IFNAMSIZ - 6) .

Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_sysfs.c diff | blob | history
Andy's Linux Kernel repo