]> Pileus Git - ~andy/linux/commit
rt2x00: Serialize TX operations on a queue.
authorGertjan van Wingerde <gwingerde@gmail.com>
Wed, 6 Jul 2011 20:56:24 +0000 (22:56 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 7 Jul 2011 17:20:57 +0000 (13:20 -0400)
commit77a861c405da75d81e9e6e32c50eb7f9777777e8
tree90003fd46901d70ae7fabfe7c31a8ad758fcfd1d
parent9352f69c9194f1dcb3e096377e5c4804ab1bb5fb
rt2x00: Serialize TX operations on a queue.

The rt2x00 driver gets frequent occurrences of the following error message
when operating under load:
phy0 -> rt2x00queue_write_tx_frame: Error - Arrived at non-free entry in the
non-full queue 2.

This is caused by simultaneous attempts from mac80211 to send a frame via
rt2x00, which are not properly serialized inside rt2x00queue_write_tx_frame,
causing the second frame to fail sending with the above mentioned error
message.

Fix this by introducing a per-queue spinlock to serialize the TX operations
on that queue.

Reported-by: Andreas Hartmann <andihartmann@01019freenet.de>
Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00queue.c
drivers/net/wireless/rt2x00/rt2x00queue.h