]> Pileus Git - ~andy/linux/commit
tpm/tpm_ppi: Do not compare strcmp(a,b) == -1
authorPeter Huewe <PeterHuewe@gmx.de>
Wed, 30 Oct 2013 19:46:55 +0000 (20:46 +0100)
committerPeter Huewe <peterhuewe@gmx.de>
Mon, 6 Jan 2014 13:37:23 +0000 (14:37 +0100)
commit747d35bd9bb4ae6bd74b19baa5bbe32f3e0cee11
tree688429e581a2d74cab3ffce355030b6885c6accf
parent38fd2c202a3d82bc12430bce5789fa2c2a406f71
tpm/tpm_ppi: Do not compare strcmp(a,b) == -1

Depending on the implementation strcmp might return the difference between
two strings not only -1,0,1 consequently
 if (strcmp (a,b) == -1)
might lead to taking the wrong branch

-> compare with < 0  instead,
which in any case is more canonical.

Cc: stable@vger.kernel.org
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
drivers/char/tpm/tpm_ppi.c